Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Treat RAID layout value '-unknown-' same as an empty value #2618

Merged
merged 1 commit into from Jul 13, 2021
Merged

Treat RAID layout value '-unknown-' same as an empty value #2618

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
9 changes: 8 additions & 1 deletion usr/share/rear/layout/save/GNU/Linux/210_raid_layout.sh
View file
Open in desktop
Expand Up @@ -68,7 +68,14 @@ if [ -e /proc/mdstat ] && grep -q blocks /proc/mdstat ; then
sparedevices=""
fi

if [ -n "$layout" ] ; then
# mdadm can print '-unknown-' for a RAID layout
# which got recently (2019-12-02) added to RAID0 (it existed before for RAID5 and RAID6 and RAID10) see
# https://git.kernel.org/pub/scm/utils/mdadm/mdadm.git/commit/Detail.c?id=329dfc28debb58ffe7bd1967cea00fc583139aca
# so we treat '-unknown-' same as an empty value to avoid that layout/prepare/GNU/Linux/120_include_raid_code.sh
# will create a 'mdadm' command in diskrestore.sh like "mdadm ... --layout=-unknown- ..." which would fail
# during "rear recover" with something like "mdadm: layout -unknown- not understood for raid0"
# see https://github.com/rear/rear/issues/2616
if test "$layout" -a '-unknown-' != "$layout" ; then
layout=" layout=$layout"
else
layout=""
Expand Down