Implement get_partition_number() to allow for easy testing and trap problems #265
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…roblems This function now traps when the partition number is not a number or spans more than two characters. Since Relax-and-Recover does not support more than 9 partitions we are not creating another artificial limit. However if we find a better way to get the partition number from inconsistent devices (those that add a partition number directly to a trailing number), I am all for that. This pull-request relates to rear#183
ghost
assigned
dagwieers
added a commit
that referenced
this pull request
Jun 28, 2013
Implement get_partition_number() to allow for easy testing and trap problems
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This function now traps when the partition number is not a number or spans more than two characters. Since Relax-and-Recover does not support more than 9 partitions we are not creating another artificial limit. However if we find a better way to get the partition number from inconsistent devices (those that add a partition number directly to a trailing number), I am all for that.
This pull-request relates to #183 and #263