New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fixed serial console for syslinux #2650
Conversation
I am not at all a serial console expert so I may confuse this or that. From plain looking at the serial console related code in ReaR
there are two different places where serial console is set up in ReaR. Setup of serial consoles in the running ReaR recovery system Currently both are specified via the boolean config variable USE_SERIAL_CONSOLE. Your new SERIAL_CONSOLE_DEVICE config variable only applies In general I prefer a single config variable with ternary (and more) semantics So in this case I would prefer to drop SERIAL_CONSOLE_DEVICE
So e.g. |
FYI: I will be "offline" until next Monday. |
The fix is absolutely syslinux & extlinux config and not related to other serial config. It may be syslinux version, hardware and bios dependent but thats something I can't tell. Those scripts do take care about different serial related config (kernel parameter and getty config):
The script I agree that a string containing devices for |
strangely multiple serial config lines work on apu2 board versions. So I will change the PR to keep the old behavior when the variable is not set. |
… - causes trouble on some machines
@DEvil0000 |
@gdha @pcahyna @DEvil0000 |
@jsmeix In case you decide to change how USE_SERIAL_CONSOLE works it may be best to merge the PR first and handle it then like the rest of the code. |
My idea of enhancing USE_SERIAL_CONSOLE as I suggested in
both the serial console for the bootloader My reasoning behind is that I assume when a user specifies e.g.
then he has a serial console only at /dev/ttyS0 and nowhere else. Or in other words: If that assumption is wrong my proposal |
@DEvil0000 |
…NSOLE_DEVICE_SYSLINUX
added the not about a near future change of USE_SERIAL_CONSOLE and SERIAL_CONSOLE_DEVICE_SYSLINUX to the comment in the file as requested. So this one should be okay for merge now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From plain looking at the code
(I am not a serial console user)
things look good to me.
@rear/contributors |
using output=usb I created a bootable USB stick with working serial on a apu board based machine. (ex6linux)
I can not find any statement in syslinux documentation if multiple
serial
lines are allowed. The docs just state the line must be the first one in the config file. On my apu board based machine I have two serial interfaces (and nothing else) but as soon as I haveserial
config lines for two different devices/ports it is not working for any of them.Only when having one serial device in the config it is working.
So this PR does two things: