Fix grub config #2661
Merged
Fix grub config #2661
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsmeix
requested changes
Jul 22, 2021
There was a problem hiding this comment.
This needs to wait until I fixed current OUTPUT=USB regressions, cf.
#2660 (comment)
jsmeix
approved these changes
Jul 27, 2021
There was a problem hiding this comment.
With #2660
and #2659 merged
this one can be also merged, cf.
#2659 (comment)
This was referenced Jul 27, 2021
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
with output=usb, partitioned gpt, bootloader grub, no efi/legacy boot on apu2 hardware with firmware 4.13.0.6
This PR fixes two bugs in grub config while improving readability of config write function a bit.