Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.adoc and removal of .travis.yml #2758

Closed
wants to merge 2 commits into from

Conversation

hpannenb
Copy link
Contributor

@hpannenb hpannenb commented Feb 8, 2022

Removed Travis CI status due to not working (any more).

Pull Request Details:
  • Type: Other

  • Impact: Low

  • Reference to related issue (URL): Ceased Travis CI testing. #2757

  • How was this pull request tested? Not required.

  • Brief description of the changes in this pull request:
    The current Travis CI integration is not working any more so its linked build status provides a misleading information and thus has been removed. The travis specific configuration file will also been removed with this PR.

Removed Travis CI status due to not working (any more).
Removal of travis specific config file.
@hpannenb hpannenb changed the title Update README.adoc Update README.adoc and removal of .travis.yml Feb 8, 2022
@pcahyna
Copy link
Member

pcahyna commented Feb 8, 2022

Hi @antonvoznia, please have a look at the removed .travis.yml. I believe the same will be trivial to implement using Packit (as it builds RPMs, it already does the equivalent of make install, and make validate can be easily added to the %check section of the spec file).

Copy link
Member

@jsmeix jsmeix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know nothing at all about Travis
but as the currently used does no longer work
I think it is right to remove it.

@jsmeix jsmeix added cleanup ReaR Project The ReaR project itself and the tooling we use to work on it. labels Feb 9, 2022
@jsmeix
Copy link
Member

jsmeix commented Feb 9, 2022

@pcahyna
I dared to assign it to you because it seems
you know at least something about that area.
Feel free to merge it when it is OK for you.

@pcahyna
Copy link
Member

pcahyna commented Feb 9, 2022

@jsmeix no problem! I think the only question is whether the non-functional .travis.yml should be removed or should be left in the tree (with a comment, perhaps) - the latter would make it easier to resurrect Travis testing in the future if anyone is interested. (Whether anyone would be interested in this is another question, given the availability of probably superior alternatives.)

@hpannenb
Copy link
Contributor Author

hpannenb commented Feb 9, 2022

@pcahyna I think leaving .travis.yml will be a good approach. I just recognised this configuration file in my yesterday's excursion.

@pcahyna
Copy link
Member

pcahyna commented Feb 9, 2022

@hpannenb ok, I then suggest that you replace the commit that removes the file by a commit that adds a comment saying that it is currently broken and why.

@hpannenb hpannenb closed this Feb 16, 2022
@hpannenb
Copy link
Contributor Author

Will create a new one.

@jsmeix
Copy link
Member

jsmeix commented Feb 16, 2022

This one is obsolete.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cleanup ReaR Project The ReaR project itself and the tooling we use to work on it. won't fix / can't fix / obsolete
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants