Backup in ISO feature #278
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's more consistent and help to prepare the "backup in iso" feature
To use that, BACKUP_URL has to use the iso://[subdirs] scheme but a different OUTPUT_URL has to be defined.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #264, I implemented that feature by moving the output phase after the backup creation but only when it's needed to integrate the backup in the ISO.
In this way, they won't be any regression for other output type such as ODBR.
It wasn't possible to keep the current order because it implies to much changes in output and a lot of code duplication, especially for the ISO copy to OUTPUT_URL.
As Dag suggested, I implemented a new iso scheme for BACKUP_URL which avoid a new option.
For instance, BACKUP_URL=iso://my_backups will copy backups in a subdir called my_backups inside the ISO image.
But, to use this feature, OUTPUT_URL needs to be defined to another location.