Merge 2768, build in packit #2784
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In layout/save/GNU/Linux/210_raid_layout.sh fixed the RAID10 layout support code as far as possible for now. Currently only 'near=...' support is (and was) implemented, cf. rear@4dbbb28 This fix was triggered by ShellCheck SC2034: param appears unused. Verify use (or export if used externally) https://github.com/koalaman/shellcheck/wiki/SC2034 SC2066: Since you double quoted this, it will not word split, and the loop will only run once https://github.com/koalaman/shellcheck/wiki/SC2066 cf. rear#1040 (comment)
Again support RAID10 "far" and "offset" layouts. Currently if there is more than one RAID10 layout value only the first one is used because according to https://unix.stackexchange.com/questions/280283/is-it-possible-to-create-a-mdadm-raid10-with-both-near-and-far-layout-options it seems it is not possible (or it does not make sense in practice) to set both "near=..." and "far=..." and we also assume it is not possible (or it does not make sense in practice) to set more than one RAID10 layout value because we I don't know what would be the mdadm command to create them, cf. rear#2768 (comment)
Do an initial general test first of all and not somewhere later in between other code.
|
sorry, bad PR. |
jsmeix
added
won't fix / can't fix / obsolete
not ReaR / invalid
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.