New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Show the users the starting point of the execution of the PRE/POS_RECOVERY_SCRIPTs #2789
Conversation
Hi, thanks for the change, I believe it would be better to do this after PR #2735 is merged, otherwise the changes would conflict. Also, is it intentional that it is done only for PRE/POST_RECOVERY_SCRIPT and not for PRE/POST_BACKUP_SCRIPT ? |
I'm ok with merging that PR after #2735. The mine one is introducing only information to the output in run time... so it's OK. What I can do is to add the same Information for PRE/POST_BACKUP_SCRIPT. What do you think? |
Yes, I would do the same change for PRE/POST_BACKUP_SCRIPT. What do you think about the changes in PR #2735 and the suggestion in the last comment there? (I think we should gradually deprecate |
I don't agree to add that new variables, but may maintain the original ones:
So, in my honest opinion, ReaR is not intended to re-implement a shell to parse all the shell grammar, letting to run an external script should be enough. |
Include the changes from #2789 i.e. use LogPrint to show the user the executed commands
Include the changes from #2789 i.e. use LogPrint to show the user the executed commands
I included the changes in this pull request |
Add PRE_RECOVERY_COMMANDS and POST_RECOVERY_COMMANDS as alternative to PRE_RECOVERY_SCRIPT and POST_RECOVERY_SCRIPT see the description in default.conf how to use them and how they work. See #2811 and see also #2735 therein in particular #2735 (comment) Additionally use LogPrint to show the user the executed commands, see #2789
With #2811 merged |
@ivarmu PRE_RECOVERY_SCRIPT and POST_RECOVERY_SCRIPT I think in particular for longer complicated things But to "just run a few simple commands" |
Add PRE_RECOVERY_COMMANDS and POST_RECOVERY_COMMANDS as alternative to PRE_RECOVERY_SCRIPT and POST_RECOVERY_SCRIPT see the description in default.conf how to use them and how they work. See rear#2811 and see also rear#2735 therein in particular rear#2735 (comment) Additionally use LogPrint to show the user the executed commands, see rear#2789
Relax-and-Recover (ReaR) Pull Request Template
Please fill in the following items before submitting a new pull request:
Pull Request Details:
Type: Enhancement
Impact: Low
Reference to related issue (URL): No issue created
How was this pull request tested?: Local VM
Brief description of the changes in this pull request: Add a LogPrint to show the user the scripts are being executed