More failsafe 200_partition_layout.sh #2802
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In layout/save/GNU/Linux/200_partition_layout.sh ensure the partition name/type entry in disklayout.conf is always set (and percent encoded if needed) at least it is set to the fallback value 'rear-noname' regardless of the 'disk_label' value, cf. #2801 (comment)
jsmeix
changed the title
In layout/save/GNU/Linux/200_partition_layout.sh ensure $disk_label is one of the supported partition tables cf. #2801 (comment)
|
My attempt here makes things even worse! That old code is so terribly obfuscated |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type: Enhancement
Impact: High
Reference to related issue (URL):
Broken 'part' entries in disklayout.conf in case of 'unknown' partition table #2801 (comment)
How was this pull request tested?
Not yet tested.
Brief description of the changes in this pull request:
In layout/save/GNU/Linux/200_partition_layout.sh
ensure the partition name/type entry in disklayout.conf
is always set (and percent encoded if needed)
at least it is set to the fallback value 'rear-noname'
regardless of the 'disk_label' value