Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change debhelpers compat level to 10 #2882

Merged
merged 1 commit into from Oct 24, 2022
Merged

change debhelpers compat level to 10 #2882

merged 1 commit into from Oct 24, 2022

Conversation

DEvil0000
Copy link
Contributor

due to warning about deprecation at least on ubuntu 22.04

dh_*: warning: Compatibility levels before 10 are deprecated (level 9 in use)

this should be changed

due to warning about deprecation at least on ubuntu 22.04
```
dh_*: warning: Compatibility levels before 10 are deprecated (level 9 in use)
```
this should be changed
@DEvil0000 DEvil0000 changed the title change compat to 10 change debhelpers compat level to 10 Oct 20, 2022
@jsmeix jsmeix requested a review from a team October 20, 2022 10:28
@jsmeix jsmeix self-assigned this Oct 20, 2022
@jsmeix jsmeix added the enhancement Adaptions and new features label Oct 20, 2022
@jsmeix jsmeix added this to the ReaR v2.8 milestone Oct 20, 2022
@jsmeix jsmeix requested a review from schlomo October 20, 2022 10:32
@jsmeix
Copy link
Member

jsmeix commented Oct 20, 2022

I know nothing at all about Debian/Ubuntu packaging
so I cannot review it - in particular I know nothing
whether or not that change could cause regressions
when building it on older Debian/Ubuntu versions.

@DEvil0000
do you perhaps know if increasing that vaule could cause
regressions when building it on older Debian/Ubuntu versions?

The last increase (from 5 to 9) happened
on Jun 27, 2017 by @schlomo via
56959b5
so perhaps @schlomo might know if increasing that vaule
could cause regressions when building it on older
Debian/Ubuntu versions?

@jsmeix jsmeix requested a review from gdha October 20, 2022 10:43
@jsmeix
Copy link
Member

jsmeix commented Oct 20, 2022

@gdha
I noticed that also you did something in the past
for Debian/Ubuntu packaging, so perhaps you might know
if increasing the vaule in packaging/debian/compat
could cause regressions when building it on older
Debian/Ubuntu versions?

@DEvil0000
Copy link
Contributor Author

I kinda know debian packaging but don't know the details of debhelpers. If there is a deprecation warning or such it is normally a good idea to follow the suggestion.

@jsmeix
Copy link
Member

jsmeix commented Oct 24, 2022

I think I will "just merge" it today afternoon.
If something breaks with package building on Debian/Ubuntu
we can fix it as needed (e.g. revert this change as a band aid).

@jsmeix jsmeix merged commit f21a6d6 into rear:master Oct 24, 2022
@jsmeix
Copy link
Member

jsmeix commented Oct 24, 2022

@DEvil0000
thank you for your continuous improvements of ReaR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Adaptions and new features fixed / solved / done
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants