Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix rear mkrescue with sesam 5.x #2894

Merged
merged 1 commit into from Dec 7, 2022
Merged

fix rear mkrescue with sesam 5.x #2894

merged 1 commit into from Dec 7, 2022

Conversation

abbbi
Copy link
Contributor

@abbbi abbbi commented Dec 4, 2022

hi,

we are evaluating shipping REAR 2.7 with the next sesam release. It appears that with REAR 2.7, mkrescue
step will fail bcs of missing libraries during functionality check:

2022-12-04 12:00:57.066647656 /opt/sesam/bin/sesam/python3/libhogweed.so.6 requires additional libraries (fatal error)
2022-12-04 12:00:57.075641526   linux-vdso.so.1 (0x00007ffc7a5ca000)
                                libnettle.so.8 => not found

adding two more directories to the backup module related LD_LIBRARY_PATH fixes this issue.

Copy link
Member

@jsmeix jsmeix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I "just approve" it because it only affects BACKUP=SESAM which I cannot test.

@jsmeix
Copy link
Member

jsmeix commented Dec 5, 2022

@abbbi
is the change sufficiently backward compatible and fail-safe
in particular when older SESAM versions are used?

For example I don't know if $SM_BIN_SMS has always a value.
If it is unset or has no value the code would evaluate to

SESAM_LD_LIBRARY_PATH=$SM_BIN_SESAM:$SM_BIN_SESAM/python3/:

but I don't know how SESAM_LD_LIBRARY_PATH works
with a trailing colon because "man bash" reads (excerpt)

PATH
...
A zero-length (null) directory name in the value of PATH
indicates the current directory.
A null directory name may appear as two adjacent colons,
or as an initial or trailing colon.

so a trailing colon makes a difference.

@jsmeix jsmeix added the enhancement Adaptions and new features label Dec 5, 2022
@jsmeix jsmeix added this to the ReaR v2.8 milestone Dec 5, 2022
@abbbi
Copy link
Contributor Author

abbbi commented Dec 5, 2022

hi,

$SM_BIN_SMS always has a value (its defined in the config file set in sesam2000ini_file)
Older sesam versions will stick to REAR 2.6 which we shipped in past
releases, i dont see an issue here regards backwards compatibility.

Reason for the issues is that SEP has obsoleted python2 to python3, and additional libraries
are now included within the python3 subdirectory. Additionally RTS components need additional
libraries from the SMS subfolder too, to be able to validate.

@jsmeix jsmeix requested a review from a team December 5, 2022 14:27
@jsmeix
Copy link
Member

jsmeix commented Dec 5, 2022

@rear/contributors
provided there are no objections from one of you
I would like to merge it next Wednesday (07. December)
in the afternoon (at Central European Time).

@jsmeix
Copy link
Member

jsmeix commented Dec 5, 2022

@abbbi
I meant when users use a current ReaR with your change
(e.g. from ReaR upstream or from their Linux distributor)
with an older SESAM version.

@abbbi
Copy link
Contributor Author

abbbi commented Dec 5, 2022

@abbbi I meant when users use a current ReaR with your change (e.g. from ReaR upstream or from their Linux distributor) with an older SESAM version.

the change should not cause any issue with older Sesam versions, in fact, i wonder why it didnt report the missing
libraries already with REAR 2.6 (seems the check in REAR 2.7 has seen some rework and is stricter now).
Anyways, our customers will (by default) always use the bundled version.

@jsmeix jsmeix merged commit 973e102 into rear:master Dec 7, 2022
@jsmeix jsmeix added fixed / solved / done external tool The issue depends on other software e.g. third-party backup tools. labels Dec 7, 2022
@jsmeix
Copy link
Member

jsmeix commented Dec 7, 2022

@abbbi
thank you for your continuous contributions to ReaR
in particular for the BACKUP=SESAM method in ReaR!

Contributions for third-party backup tool support in ReaR
are much appreciated because we at ReaR upstream
usually do not have those third-party backup tools
so we totally depend on contributions from people
who use and know about third-party backup tools
(users or ideally even developers).

@jsmeix jsmeix removed the request for review from a team December 7, 2022 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Adaptions and new features external tool The issue depends on other software e.g. third-party backup tools. fixed / solved / done
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants