BACKUP=BAREOS: fix bconsole CLI argument format #2901
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use appropriate CLI argument format depending on the installed bconsole version.
gdha
approved these changes
Dec 28, 2022
gdha
added
minor bug
jsmeix
approved these changes
Jan 2, 2023
jsmeix
added
enhancement
jsmeix
changed the title
|
@rear/contributors |
jsmeix
added a commit
that referenced
this pull request
Jan 5, 2023
Explicit comment that explains the Bareos 22 introduced breaking change
how its CLI tools (such as bconsole) parse the arguments ('-xc' vs. '--xc')
cf. #2901
antonvoznia
pushed a commit
to antonvoznia/rear
that referenced
this pull request
Feb 21, 2023
Explicit comment that explains the Bareos 22 introduced breaking change
how its CLI tools (such as bconsole) parse the arguments ('-xc' vs. '--xc')
cf. rear#2901
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use appropriate CLI argument format depending on the installed bconsole version.
Relax-and-Recover (ReaR) Pull Request Template
Please fill in the following items before submitting a new pull request:
Pull Request Details:
Type: Bug Fix / New Feature / Enhancement / Other?
Bug Fix
Impact: Low / Normal / High / Critical / Urgent
Normal
Reference to related issue (URL):
Bareos 22 bconsole switch parsing breaking change #2900
How was this pull request tested?
Manually, on multiple KVM hosts running Bareos 22 and Bareos 21 release.
Brief description of the changes in this pull request:
Bareos 22 introduced breaking change in how the CLI tools (such as bconsole) parse the arguments. This pull request fixes the issue when calling the
bconsole -xccommand.Before bconsole configuration export command is called, the script will check the bconsole version and will use the appropriate argument format later on.
If bconsole is called with incorrect argument format, the utility will terminate with 113 exit code, and
rear mkrescuewill fail as well.