Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding all ReaR validations I got in the last 2 years #2934

Merged
merged 1 commit into from Feb 16, 2023

Conversation

schlomo
Copy link
Member

@schlomo schlomo commented Feb 15, 2023

We actually got some great feedback

@gdha
Copy link
Member

gdha commented Feb 15, 2023

@schlomo I wonder if we still need to add this into our sources? This is something that should be part of the documentation.

@schlomo
Copy link
Member Author

schlomo commented Feb 15, 2023

The fact that these still come in shows me that it is still relevant. Also, the info is shown at the end of rear dump and I really like this immediate feedback to users with "somebody else was happy to use ReaR on your OS".

I'd see showing this on the ReaR homepage as an additional feature and we could automatically extract it from the source location here as part of the build process, but we would have to struggle with two repos and triggering GH workflow runs in the ReaR docs repo each time something changes in the validations... Not a big prio IMHO.

Finally, people submit it and I want to honor them and their efforts by publishing it. It was actually my lapse to not do so diligently and I'll go back to publish them as I receive them. This PR is therefore only about catching up.

@schlomo schlomo changed the title Adding all ReaR validations I god in the last 2 years Adding all ReaR validations I got in the last 2 years Feb 16, 2023
@schlomo schlomo merged commit 783c7ba into master Feb 16, 2023
@schlomo schlomo deleted the adding-recent-validations branch February 16, 2023 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants