Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not leak the SSH_ROOT_PASSWORD value into the log file #2986

Merged
merged 4 commits into from May 14, 2023

Conversation

jsmeix
Copy link
Member

@jsmeix jsmeix commented May 12, 2023

Do not leak the SSH_ROOT_PASSWORD value into the log file:
In build/default/500_ssh_setup.sh
rescue/default/500_ssh.sh
restore/YUM/default/970_set_root_password.sh
restore/ZYPPER/default/970_set_root_password.sh
run commands that deal with SSH_ROOT_PASSWORD
in a confidential way via

{ confidential_command ; } 2>/dev/null

see #2967

This fixes by the way also ZYPPER_ROOT_PASSWORD and YUM_ROOT_PASSWORD, see
#2967 (comment)

Do not leak the SSH_ROOT_PASSWORD value into the log file:
In build/default/500_ssh_setup.sh
rescue/default/500_ssh.sh
restore/YUM/default/970_set_root_password.sh
restore/ZYPPER/default/970_set_root_password.sh
run commands that deal with SSH_ROOT_PASSWORD
in a confidential way via { confidential_command ; } 2>/dev/null
see #2967
@jsmeix jsmeix added this to the ReaR v2.8 milestone May 12, 2023
@jsmeix jsmeix self-assigned this May 12, 2023
@jsmeix
Copy link
Member Author

jsmeix commented May 12, 2023

@rear/contributors
I would like to merge it on Monday afternoon
unless there are objections, see also
#2985 (comment)

@schlomo schlomo merged commit 3333cf8 into master May 14, 2023
16 checks passed
@schlomo schlomo deleted the jsmeix-hide-SSH_ROOT_PASSWORD branch May 14, 2023 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants