-
Notifications
You must be signed in to change notification settings - Fork 246
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update 200_check_usb_layout.sh #3030
Conversation
Issue an error message and exit if USB_DEVICE_FILESYSTEM is invalid, instead of setting it to "ext3". It's safer to fail due to configuation errors than to ignore/fix them silently. Fixes: issue rear#3029 Signed-off-by: Carlos Santos <casantos@redhat.com>
@casantos I think it is not a bug because conf/default.conf reads
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From plain looking at the code changes it looks good to me
@rear/contributors I would like to merge it on Thursday afternoon |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thank you for the change, I think that silently changing user's settings to something else because we don't like them is a bad idea (except for special defaults like the empty string).
Yes, I fully agree with you,
The more I am thinking about it the more I think that |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch, thank you!
Issue an error message and exit if USB_DEVICE_FILESYSTEM is invalid, instead of setting it to "ext3". It's safer to fail due to configuation errors than to ignore/fix them silently.
Fixes: issue #3029
Type: Bug Fix
Impact: Low
Reference to related issue (URL): ReaR should issue an error message and exit if USB_DEVICE_FILESYSTEM is invalid #3029
How was this pull request tested?
Ran
rear mkbackup
with a configuration containingBrief description of the changes in this pull request:
Issue an error message and exit if USB_DEVICE_FILESYSTEM is invalid.