Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

In DoExitTasks() skip 'sleep 3' when all went well #3038

Merged
merged 1 commit into from Aug 8, 2023

Conversation

jsmeix
Copy link
Member

@jsmeix jsmeix commented Aug 7, 2023

  • Type: Enhancement

  • Impact: Low

  • How was this pull request tested?

Before:

# time usr/sbin/rear help
...
Use 'rear -v help' for more advanced commands.
[here nothing happens for 3 seconds]

real    0m3.690s
user    0m0.629s
sys     0m0.254s

With the change of this pull request:

# time usr/sbin/rear help
...
Use 'rear -v help' for more advanced commands.

real    0m0.686s
user    0m0.644s
sys     0m0.234s
  • Brief description of the changes in this pull request:

In the DoExitTasks function skip 'sleep 3'
when all went well and DoExitTasks is called at normal exit
to avoid needless 3 seconds delay of normal end of program.

In the DoExitTasks function skip 'sleep 3'
when all went well and DoExitTasks is called at normal exit
to avoid needless 3 seconds delay of normal end of program.
@jsmeix jsmeix added the enhancement Adaptions and new features label Aug 7, 2023
@jsmeix jsmeix added this to the ReaR v2.8 milestone Aug 7, 2023
@jsmeix jsmeix self-assigned this Aug 7, 2023
@jsmeix jsmeix requested a review from a team August 7, 2023 09:34
Copy link
Member

@schlomo schlomo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Big thanks @jsmeix - I was already annoyed by that delay.

@jsmeix
Copy link
Member Author

jsmeix commented Aug 8, 2023

@schlomo
thank you for your review!

@rear/contributors
I will merge it today afternoon unless objections appear.

@jsmeix jsmeix merged commit 345ae39 into master Aug 8, 2023
15 checks passed
@jsmeix jsmeix deleted the jsmeix-normal-exit-without-delay branch August 8, 2023 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Adaptions and new features fixed / solved / done
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants