Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unnecessary curly braces in var expansion #3046

Merged
merged 1 commit into from Sep 11, 2023

Conversation

pcahyna
Copy link
Member

@pcahyna pcahyna commented Sep 8, 2023

Pull Request Details:
  • Type: Cleanup

  • Impact: Low

  • Reference to related issue (URL):

  • How was this pull request tested?
    Backup and recovery on RHEL 9: the log contains

2023-09-07 09:16:51.683209039 Including finalize/GNU/Linux/260_rename_diskbyid.sh
2023-09-07 09:16:51.751526112 Migrating disk-by-id mappings in certain restored files in /mnt/local to current disk-by-id mappings ...

and the recovered system has backup files:

# find /etc -name \*.rearbak
/etc/lvm/devices/system.devices.rearbak
/etc/lvm/lvm.conf.rearbak
/etc/fstab.rearbak

showing that the creation of backups still works.

Inspired by discussion of PR #3043 : #3043 (comment)

@jsmeix
Copy link
Member

jsmeix commented Sep 8, 2023

@pcahyna
only by the way FYI:
I think we have very many other code places
with unnecessary curly braces in var expansion
so it is basically hopeless to try to fix them all.
But if one detects them by chance while working on some code
it could make sense to also clean up unnecessary curly braces.

@jsmeix jsmeix added the cleanup label Sep 8, 2023
@jsmeix jsmeix added this to the ReaR v2.8 milestone Sep 8, 2023
@pcahyna
Copy link
Member Author

pcahyna commented Sep 8, 2023

@jsmeix indeed that's what did here: the new code in #3043 had this problem copied from finalize/GNU/Linux/260_rename_diskbyid.sh, so now I fixed the source for consistency.

@pcahyna pcahyna merged commit 879e173 into rear:master Sep 11, 2023
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants