-
Notifications
You must be signed in to change notification settings - Fork 246
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ErrorIfDeprecated when GRUB Legacy is used #3128
Conversation
In layout/save/default/450_check_bootloader_files.sh BugError when GRUB Legacy is used as bootloader see #3127
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Love it @jsmeix!
Curently some tests fail exactly because of those changes
@pcahyna |
@jsmeix I will have a look. I am about to change this file anyway because of other issues. |
@pcahyna |
@jsmeix please don't. This change would break all Fedora and RHEL versions on machines using BIOS. (EDIT: By this I mean it would force all users to specify BOOTLOADER in local.conf.) I investigated the situation and will send you a PR that corrects the code, please stay tuned. Sorry for the delay. |
@jsmeix by the way, I suppose there is still |
Note that this drops support for RHEL 6, CentOS 6 and Scientific Linux 6: |
@pcahyna Don't worry. You could do a review in GitHub and "request changes" |
I considered it, but I don't have any specific changes to request beyond the general "fix the failure", which would be a much larger work than this PR, and it is more efficient if I do it in a separate PR, as I have studied the code in detail already. @jsmeix could you please mark the PR as Draft? By the way, I am glad that our CI done by @antonvoznia is showing real benefits :-) |
@pcahyna @antonvoznia In particular for this pull request I did not expect |
@pcahyna |
@pcahyna regarding your Yes, see my initial description
cf. the code around |
@jsmeix sorry, I should have read the message more carefully, as it already indicates where the code got the value from. Since SUSE continues to use |
@pcahyna |
@pcahyna On my openSUSE Leap 15.5
So in particular LOADER_TYPE must be one of
|
@jsmeix Red Hat does not case much about support for older RHEL versions ( < RHEL 9) in new ReaR versions. We are not going to update ReaR in the old versions, only backport changes if necessary. Support for anything than the latest one or two releases is merely a service to the users of the upstream code. Unfortunately, I have no idea how many of them are still out there. I suspect that RHEL 6 is still widely deployed, but I don't know what is the overlap between RHEL 6 users and users of current ReaR code. I have an idea, I found the function |
@jsmeix thanks for the research on the situation on SUSE, I will not care about hybrid boot when bootloader is derived from |
We used to distinguish between GRUB and GRUB2 when reinstalling the bootloader. This meant that the saved bootloader was wrong: GRUB for GRUB2. Detect GRUB2 earlier, already at the moment when we guess the bootloader, and save the correct value. This should help with the problem reported in PR #3128 (misdetection of GRUB2 as GRUB on any non-SUSE distro).
We used to distinguish between GRUB and GRUB2 when reinstalling the bootloader. This meant that the saved bootloader was wrong: GRUB for GRUB2. Detect GRUB2 earlier, already at the moment when we guess the bootloader, and save the correct value. This should help with the problem reported in PR #3128 (misdetection of GRUB2 as GRUB on any non-SUSE distro).
I will use ErrorIfDeprecated when GRUB Legacy is used |
I close this one and - when time permits - I will |
We used to distinguish between GRUB and GRUB2 when reinstalling the bootloader. This meant that the saved bootloader was wrong: GRUB for GRUB2. Detect GRUB2 earlier, already at the moment when we guess the bootloader, and save the correct value. This should help with the problem reported in PR rear#3128 (misdetection of GRUB2 as GRUB on any non-SUSE distro). (cherry picked from commit ac72e6d)
We used to distinguish between GRUB and GRUB2 when reinstalling the bootloader. This meant that the saved bootloader was wrong: GRUB for GRUB2. Detect GRUB2 earlier, already at the moment when we guess the bootloader, and save the correct value. This should help with the problem reported in PR #3128 (misdetection of GRUB2 as GRUB on any non-SUSE distro).
We used to distinguish between GRUB and GRUB2 when reinstalling the bootloader. This meant that the saved bootloader was wrong: GRUB for GRUB2. Detect GRUB2 earlier, already at the moment when we guess the bootloader, and save the correct value. This should help with the problem reported in PR rear#3128 (misdetection of GRUB2 as GRUB on any non-SUSE distro).
Type: Cleanup
Impact: Low
Hopefully even no impact because I hope
nobody uses current ReaR on a system
that uses GRUB Legacy as bootloader
Reference to related issue (URL):
Drop GRUB Legacy support and remove its code in ReaR #3127
How was this pull request tested?
"rear mkrescue" still works for me on openSUSE Leap 15.5
I get
so I have GRUB2 in var/lib/rear/recovery/bootloader
In layout/save/default/450_check_bootloader_files.sh
BugError when GRUB Legacy is used as bootloader
so we get user reports when GRUB Legacy is still used