Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve the description of AUTOEXCLUDE_PATH #3131

Merged
merged 1 commit into from Jan 18, 2024

Conversation

pcahyna
Copy link
Member

@pcahyna pcahyna commented Jan 17, 2024

Pull Request Details:
pvcreate /dev/vdb
vgcreate testvg /dev/vdc
vgcreate testvg /dev/vdb
lvcreate -L 1G testvg -n testlv 
mkfs.xfs /dev/testvg/testlv
lvcreate -L 1G testvg -n testlv2
mkfs.xfs /dev/testvg/testlv2
mount /dev/testvg/testlv /mnt
mkdir /mnt/test
mount  /dev/testvg/testlv2 /mnt/test

now rear savelayout creates disklayout.conf with this:

fs /dev/mapper/testvg-testlv /mnt xfs uuid=9f9a9874-0325-43e0-9979-6849109c44a9 label=  options=rw,relatime,attr2,inode64,logbufs=8,logbsize=32k,noquota
#fs /dev/mapper/testvg-testlv2 /mnt/test xfs uuid=b6dd2e35-2e7a-495a-a219-4e38b41a3530 label=  options=rw,relatime,attr2,inode64,logbufs=8,logbsize=32k,noquota
  • Description of the changes in this pull request:

Separate the example of AUTOEXCLUDE_PATH handling from the treatment of /tmp. /tmp is a bad example, because it is handled specially by the default setting of another config variable (BACKUP_PROG_EXCLUDE). Use /mnt as an example for AUTOEXCLUDE_PATH instead and make clear that AUTOEXCLUDE_PATH=( /tmp ) does not exclude files under /tmp from the backup and an independent setting is used for that purpose.

Separate the example of AUTOEXCLUDE_PATH handling from the treatment of
/tmp. /tmp is a bad example, because it is handled specially by the
default setting of another config variable (BACKUP_PROG_EXCLUDE).
Use /mnt as an example for AUTOEXCLUDE_PATH instead and make clear that
AUTOEXCLUDE_PATH=( /tmp ) does not exclude files under /tmp from the
backup and an independent setting is used for that purpose.
@pcahyna pcahyna added this to the ReaR v2.8 milestone Jan 17, 2024
@pcahyna pcahyna requested a review from a team January 17, 2024 14:27
@pcahyna pcahyna self-assigned this Jan 17, 2024
Copy link
Member

@jsmeix jsmeix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pcahyna
thank you for the more clear description!

@pcahyna
Copy link
Member Author

pcahyna commented Jan 18, 2024

thanks for the review! merging

@pcahyna pcahyna merged commit 5e6cbdd into rear:master Jan 18, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants