Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#3067 use exit code of nc to check BACULA directory availability #3182

Merged
merged 2 commits into from Apr 19, 2024
Merged

#3067 use exit code of nc to check BACULA directory availability #3182

merged 2 commits into from Apr 19, 2024

Conversation

gdha
Copy link
Member

@gdha gdha commented Mar 18, 2024 •
edited by jsmeix

Relax-and-Recover (ReaR) Pull Request Template

Please fill in the following items before submitting a new pull request:

Pull Request Details:

@gdha
#3067 use exit code of nc to check BACULA directory availability
f7f29a2 
Signed-off-by: gdha <gratien.dhaese@gmail.com>
@gdha gdha self-assigned this Mar 18, 2024
@gdha gdha added minor bug An alternative or workaround exists external tool The issue depends on other software e.g. third-party backup tools. labels Mar 20, 2024
@gdha
#3082 improved the way to grab the BACULA_DIRECTOR and BACULA_CLIENT
776d6f2 
Signed-off-by: gdha <gratien.dhaese@gmail.com>
@gdha gdha requested review from schlomo, jsmeix and pcahyna April 9, 2024 06:40
@gdha
Copy link
Member Author

gdha commented Apr 18, 2024

@rear/contributors what shall we do with this PR? Merge or drop?

@jsmeix jsmeix mentioned this pull request Apr 19, 2024
Open
jsmeix
jsmeix approved these changes Apr 19, 2024
View reviewed changes
Copy link
Member

@jsmeix jsmeix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I cannot actually review it
because I do not have BACULA
but from plain looking at the code changes
I don't see something obviously wrong
so I approve it "bona fide"

@jsmeix
Copy link
Member

jsmeix commented Apr 19, 2024

I think we should merge it
regardless that the users who had the issues do not respond
because the changes intend to improve things.
I.e. I think better try to improve things than do nothing.

@jsmeix jsmeix mentioned this pull request Apr 19, 2024
Merged
@gdha gdha added this to the ReaR v2.8 milestone Apr 19, 2024
@gdha gdha merged commit 410559f into master Apr 19, 2024
20 of 21 checks passed
@gdha gdha deleted the gdha-bacula3067 branch April 19, 2024 08:23
@gdha
Copy link
Member Author

gdha commented Apr 19, 2024

This PR may fix issues #3067 and #3082 - we will see what the future brings...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsmeix jsmeix jsmeix approved these changes

@schlomo schlomo Awaiting requested review from schlomo

@pcahyna pcahyna Awaiting requested review from pcahyna

Assignees

@gdha gdha

Labels
external tool The issue depends on other software e.g. third-party backup tools. fixed / solved / done minor bug An alternative or workaround exists
Projects
None yet
Milestone
ReaR v2.8
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@gdha @jsmeix