-
Notifications
You must be signed in to change notification settings - Fork 247
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
On hold: New source_variable_from_file() #3203
Draft
jsmeix
wants to merge
11
commits into
master
Choose a base branch
from
jsmeix-get_var_from_file
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Commits on Apr 9, 2024
-
New global function get_var_from_file()
In lib/global-functions.sh added new function get_var_from_file() see #3171
Configuration menu - View commit details
-
Copy full SHA for c060ecc - Browse repository at this point
Copy the full SHA c060eccView commit details -
Dropped the final '|| return 1' from the get_var_from_file() implementation, see #3203 (comment)
Configuration menu - View commit details
-
Copy full SHA for ef14f5f - Browse repository at this point
Copy the full SHA ef14f5fView commit details
Commits on Apr 11, 2024
-
Explain why we source the file in a separated shell and why stdout of the sourced file must be discarded and add specific URLs to pull request comments that show our resoning behind
Configuration menu - View commit details
-
Copy full SHA for 0dfc2a8 - Browse repository at this point
Copy the full SHA 0dfc2a8View commit details -
Configuration menu - View commit details
-
Copy full SHA for 853d65d - Browse repository at this point
Copy the full SHA 853d65dView commit details -
Typo fix in comment: Removed false full stop '.' because the sentence does not end there.
Configuration menu - View commit details
-
Copy full SHA for 80c8652 - Browse repository at this point
Copy the full SHA 80c8652View commit details -
Typo fix in comment "interits" -> "inherits"
Configuration menu - View commit details
-
Copy full SHA for 1e9b17c - Browse repository at this point
Copy the full SHA 1e9b17cView commit details
Commits on Apr 12, 2024
-
Renamed get_var_from_file into get_shell_file_config_variable to tell what that function actually is about, see #3203 (comment)
Configuration menu - View commit details
-
Copy full SHA for 12c3ccb - Browse repository at this point
Copy the full SHA 12c3ccbView commit details -
Configuration menu - View commit details
-
Copy full SHA for f947c3a - Browse repository at this point
Copy the full SHA f947c3aView commit details
Commits on Apr 15, 2024
-
Renamed get_shell_file_config_variable into source_variable_from_file to make it explicit that the file is sourced.
Configuration menu - View commit details
-
Copy full SHA for f79454f - Browse repository at this point
Copy the full SHA f79454fView commit details -
Added new helper function is_trustworthy_for_root to check if only 'root' could have written a file which makes such files trustworthy to be used by ReaR and call that helper function in source_variable_from_file(), see #3203 (comment)
Configuration menu - View commit details
-
Copy full SHA for 5cafe6d - Browse repository at this point
Copy the full SHA 5cafe6dView commit details -
Fixed is_trustworthy_for_root: Only check that the owner name is 'root' because the group does not matter when it has no write permissions. Treat files with an ACL as untrustworthy to be on the safe side because (at last currently) ACLs are not checked. See #3203 (comment)
Configuration menu - View commit details
-
Copy full SHA for 5430f62 - Browse repository at this point
Copy the full SHA 5430f62View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.