Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

On hold: New source_variable_from_file() #3203

Draft
wants to merge 11 commits into
base: master
Choose a base branch
from

Commits on Apr 9, 2024

  1. New global function get_var_from_file()

    In lib/global-functions.sh added
    new function get_var_from_file()
    see #3171
    jsmeix committed Apr 9, 2024
    Configuration menu
    Copy the full SHA
    c060ecc View commit details
    Browse the repository at this point in the history
  2. Update global-functions.sh

    Dropped the  final '|| return 1' from the
    get_var_from_file() implementation, see
    #3203 (comment)
    jsmeix committed Apr 9, 2024
    Configuration menu
    Copy the full SHA
    ef14f5f View commit details
    Browse the repository at this point in the history

Commits on Apr 11, 2024

  1. Update global-functions.sh

    Explain why we source the file in a separated shell
    and why stdout of the sourced file must be discarded
    and add specific URLs to pull request comments
    that show our resoning behind
    jsmeix committed Apr 11, 2024
    Configuration menu
    Copy the full SHA
    0dfc2a8 View commit details
    Browse the repository at this point in the history
  2. Update global-functions.sh

    Typo fix "the the" -> "the"
    jsmeix committed Apr 11, 2024
    Configuration menu
    Copy the full SHA
    853d65d View commit details
    Browse the repository at this point in the history
  3. Update global-functions.sh

    Typo fix in comment: Removed false full stop '.'
    because the sentence does not end there.
    jsmeix committed Apr 11, 2024
    Configuration menu
    Copy the full SHA
    80c8652 View commit details
    Browse the repository at this point in the history
  4. Update global-functions.sh

    Typo fix in comment "interits" -> "inherits"
    jsmeix committed Apr 11, 2024
    Configuration menu
    Copy the full SHA
    1e9b17c View commit details
    Browse the repository at this point in the history

Commits on Apr 12, 2024

  1. Update global-functions.sh

    Renamed get_var_from_file into get_shell_file_config_variable
    to tell what that function actually is about, see
    #3203 (comment)
    jsmeix committed Apr 12, 2024
    Configuration menu
    Copy the full SHA
    12c3ccb View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    f947c3a View commit details
    Browse the repository at this point in the history

Commits on Apr 15, 2024

  1. Update global-functions.sh

    Renamed get_shell_file_config_variable
    into source_variable_from_file
    to make it explicit that the file is sourced.
    jsmeix committed Apr 15, 2024
    Configuration menu
    Copy the full SHA
    f79454f View commit details
    Browse the repository at this point in the history
  2. Update global-functions.sh

    Added new helper function is_trustworthy_for_root
    to check if only 'root' could have written a file
    which makes such files trustworthy to be used by ReaR
    and call that helper function in source_variable_from_file(), see
    #3203 (comment)
    jsmeix committed Apr 15, 2024
    Configuration menu
    Copy the full SHA
    5cafe6d View commit details
    Browse the repository at this point in the history
  3. Update global-functions.sh

    Fixed is_trustworthy_for_root:
    Only check that the owner name is 'root' because
    the group does not matter when it has no write permissions.
    Treat files with an ACL as untrustworthy to be on the safe side
    because (at last currently) ACLs are not checked.
    See #3203 (comment)
    jsmeix committed Apr 15, 2024
    Configuration menu
    Copy the full SHA
    5430f62 View commit details
    Browse the repository at this point in the history