Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

integrate SEP Sesam backup software client into REAR boot image #324

Merged
merged 2 commits into from Nov 7, 2013
Merged

integrate SEP Sesam backup software client into REAR boot image #324

merged 2 commits into from Nov 7, 2013

Conversation

ghost
Copy link

@ghost ghost commented Nov 6, 2013

Dear REAR maintainers,

we have re-arranged the sesam integration into rear in a more sane way
now, attached you can find the diffs against the current github
repository, here are the explanations for the changes:

Makefile | 6 +++---

a short patch to honor the DESTDIR variable during install-bin, so
REAR can work from a random directory it has been installed to
(make install DESTDIR=/tmp/installation/)

usr/share/rear/conf/default.conf | 9 +++++++++

add the default COPY_AS_IS_SESAM values to default.conf

usr/share/rear/prep/SESAM/default/40_prep_sesam.sh | 63 ++++++++++++++++++++

this will detect a possible SEP Sesam client installation on the system and will include the sesam components needed to run a sesam client within the boot image. As SEP Sesam users have the possibility to either
install via RPM packages or custom .tar.gz packages it makes no sense to
use standard values like tsm or bacula, because the installation paths
are up to the user (with .tar.gz based SEP Client installation packages)

Auto detecting is done via /etc/sesam2000.ini which contains the paths
in both cases.

.../restore/SESAM/default/40_restore_backup.sh | 15 +++++

just a short note to the user how to proceed with the restore after
disk layout has been done.

.../SESAM/default/90_create_missing_directories.sh | 9 +++

just a copy from the default workflow which helps here aswell.

.../system-setup.d/59-start-sesam-client.sh

a short script to start the sesam client via init script during boot
of the iso if it contains the sesam client.

@ghost ghost assigned gdha Nov 7, 2013
gdha added a commit that referenced this pull request Nov 7, 2013
integrate SEP Sesam backup software client into REAR boot image
@gdha gdha merged commit 317e75b into rear:master Nov 7, 2013

Log "Detected Sesam Installation"

SM_INI=`grep SM_INI /etc/sesam2000.ini | cut -d '=' -f 2`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use $(...) notation. We try to write the bash code so that it is also easy to read.

BTW, you could probably do make this code simpler by using something like

while IFS== read key value ; do
    case "$key" in
        gv_ro) SESAM_BIN_DIR="$value" ;;
        gv_rw) SESAM_VAR_DIR="$value" ;;
    esac
done <"$SM_INI"

Shorter, faster and easier to read. The trick is to use and IFS of = and read to split the ini file into key/value pairs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants