Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

do not use $SHARE_DIR in sesam startup script as it is not set which results in cl... #343

Closed
wants to merge 1 commit into from

Conversation

abbbi
Copy link
Contributor

@abbbi abbbi commented Dec 9, 2013

hi,

$SHARE_DIR is not set while startup scripts are executed (dhclient for example hardcodes the directory), this
makes the sesam client fail during startup. Simple fix attached which hardodes the directory here.

@ghost ghost assigned gdha Dec 9, 2013
@gdha
Copy link
Member

gdha commented Dec 9, 2013

Perhaps, it would be better that we write our main variables into /etc/rear/rescue.conf so that we can have a consistent behavior throughout our system-setup scripts

If we all agree then I'll add the following variables always to the rescue.conf file (this conf is sourced by setup-setup)

SHARE_DIR
CONFIG_DIR
VAR_DIR
LOG_DIR

@schlomo
Copy link
Member

schlomo commented Dec 9, 2013

@gdha, this is a great idea! Thanks!

On 9 December 2013 11:56, gdha notifications@github.com wrote:

Perhaps, it would be better that we write our main variables into
/etc/rear/rescue.conf so that we can have a consistent behavior
throughout our system-setup scripts

If we all agree then I'll add the following variables always to the
rescue.conf file (this conf is sourced by setup-setup)

SHARE_DIR
CONFIG_DIR
VAR_DIR
LOG_DIR


Reply to this email directly or view it on GitHubhttps://github.com//pull/343#issuecomment-30122535
.

gdha added a commit that referenced this pull request Dec 9, 2013
… the system-setup scripts) we source the important variables for rear from now on in rescue.conf

Is related to issue #343
gdha added a commit that referenced this pull request Dec 9, 2013
@gdha
Copy link
Member

gdha commented Dec 9, 2013

@abbbi if you use the latest github sources then your pull request is no longer necessary. It was good to bring this to our attention

@gdha gdha closed this Jan 3, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants