Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added "$OUTPUT_PREFIX/" to PXE (kernel and initrd) locations and solved vlan support error #380

Merged
merged 1 commit into from Mar 25, 2014

Conversation

didacog
Copy link
Contributor

@didacog didacog commented Mar 25, 2014

No description provided.

@@ -220,7 +220,7 @@ if test -d /proc/net/vlan ; then
# we might need it if we ever want to implement VLAN Migration
echo "modprobe 8021q" >>$netscript
echo "sleep 5" >>$netscript
VLANS=( $(ls /proc/net/vlan/vlan*) )
VLANS=( $(ls /proc/net/vlan/* | grep -v config) )
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please give an example where this was neccessary?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When OUTPUT=PXE, rear assumes by default OUTPUT_PREFIX="$HOSTNAME" and if not exist on NFS (BACKUP=NETFS) creates folder named $HOSTNAME and puts all rescue files inside. In this situation, the rear-$hostname file can not locate the kernel and initrd inside $HOSTNAME NFS folder by default if you have TFTP_ROOT on NFS base.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the vlan case, you are assuming vlan interface names are vlan* but it's not true, it can be ethX.vlanID, .... and if you test the code get error message that config device not exists. that is the config vlan file listed in ls.

schlomo added a commit that referenced this pull request Mar 25, 2014
Added "$OUTPUT_PREFIX/" to PXE (kernel and initrd) locations and solved vlan support error.
@schlomo schlomo merged commit fc3c7ed into rear:master Mar 25, 2014
@schlomo
Copy link
Member

schlomo commented Mar 25, 2014

Thanks a lot for helping to improve ReaR

@didacog
Copy link
Contributor Author

didacog commented Mar 25, 2014

It's a pleasure!! ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants