improve network configuration detection #530
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t for VLAN-over-bonding
|
@schlomo what do you think of this pull request? After reviewing this I think it can work as delivered (not tested yet). |
|
Wow! Cool thing and absolutely good idea to stop depending on the interface names. Maybe it would even help #655 (does it?) My 2 ct:
Yes, I am in favour of this code if we can establish that it does not break a supported OS / OS version. |
gdha
added a commit
that referenced
this pull request
Sep 25, 2015
improve network configuration detection - be careful - testing is very much appreciated on DEV environments. DO NOT USE this code in *production* yet!!!!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The changed 31_network_devies.sh does two things different than before:
It doesn't depend on a name based guess for identifing a network device as physical.
It now gets the list of all network devices from /sys/class/net, and 'subtracts' the list of virtual network devices from /sys/devices/virtual/net.
It supports VLANs ontop of a bonding interface as well as bonding over multiple VLAN interfaces.
Before it brings up a VLAN, it checks whether its parent device is a bonding interface. If yes, the parent is configured first. Same goes for bonding interfaces.
I hope I didn't introduce any regressions or broke something... :-/