Generic basic btrfs support plus proposed fix for issue#533 (udevadm settle) #538
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(which calls "udevadm settle"). Have my_udevsettle before and after each parted and partprobe call which result duplicated consecutive my_udevsettle calls in diskrestore.sh but it is fail-safe this way and two consecutive "udevadm settle" do not cause any harm and at least the second one returns immediately. Do not specify a non-default timeout for "udevadm settle" because the default timeout (120 seconds according to my udevadm man page) is certainly "the right thing" from the udev authors who know much better than I what the most reasonable default is. If "udevadm settle" fails, the whole diskrestore.sh fails because it has "set -e" which is correct because "rear recover" must not blindly proceed in case of errors.
see #497 and https://bugzilla.opensuse.org/show_bug.cgi?id=908854 Currently it works btrfs filesystem by btrfs filesystem. Therefore it probably fails if there are "weaved btrfs subvolume mounts" which means - a subvolume sv1 on a btrfs on /dev/sdXn is mounted at a mountpoint directory that belongs to a btrfs on /dev/sdYm and - a subvolume sv2 on a btrfs on /dev/sdYm is mounted at a mountpoint directory that belongs to a btrfs on /dev/sdXn in particular when the mountpoint directories are no plain directories but also subvolumes sv3 and sv4 on any of the btrfs filesystems.
gdha
added a commit
that referenced
this pull request
Jan 25, 2015
Generic basic btrfs support plus proposed fix for issue#533 (udevadm settle)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #497
and #533