Notify user that mkinitrd is running #675
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@rowens275 I am a bit confused with your pull request as it tries to push changes which were already applied. Perhaps your base is wrong? See http://2buntu.com/articles/1459/keeping-your-forked-repo-synced-with-the-upstream-source/ for a nice how-to... |
|
I believe I had updated my base. When I click on the "Files Changed" link here: https://github.com/rear/rear/pull/675/files And the following file is being removed (it's no longer needed if the two above changes are made): Do you see something different? |
gdha
added a commit
that referenced
this pull request
Oct 28, 2015
Notify user that mkinitrd is running
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I ran into some scenarios where it appeared that ReaR had hung, but in fact it was running mkinitrd. This is confusing in particular when the workflow dictates the user must hit enter to continue, and then mkinitrd starts but produces no output for 30 seconds or more.
Currently the BACKUP=FDRUPSTREAM workflow deals with this by running usr/share/rear/restore/FDRUPSTREAM/default/29_notify_of_delay.sh. But it is probably better for all users to instead include on-screen notification that mkinitrd is running.
If you guys would prefer to leave things the way they are, I am ok with that.