Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Packaging: fix "make rpm" #735

Merged
merged 10 commits into from Dec 9, 2015
Merged

Packaging: fix "make rpm" #735

merged 10 commits into from Dec 9, 2015

Conversation

pavoldomin
Copy link
Contributor

After the introduction of read-only variables (#710), make rpm fails with:

...
== Building RPM package rear--git201512081908 ==
rpmbuild -tb --clean \
                --define "_rpmfilename %%{NAME}-%%{VERSION}-%%{RELEASE}.%%{ARCH}.rpm" \
                --define "debug_package %{nil}" \
                --define "_rpmdir %(pwd)" rear--git201512081908.tar.gz
error: line 11: Empty tag: Version:
make: *** [rpm] Error 1

This patch addresses this issue.

@gdha gdha added the bug The code does not do what it is meant to do label Dec 9, 2015
@gdha gdha added this to the Rear v1.18 milestone Dec 9, 2015
@gdha gdha self-assigned this Dec 9, 2015
gdha added a commit that referenced this pull request Dec 9, 2015
@gdha gdha merged commit 78e6022 into rear:master Dec 9, 2015
@jsmeix
Copy link
Member

jsmeix commented Dec 9, 2015

@pavoldomin
many thanks for spotting and fixing that unexpected
regression of my #710
and in general many thanks for all your valuable
contribution to Relax-and-Recover!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug The code does not do what it is meant to do
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants