fixed third time bash 3.x errors in 31_network_devices.sh #767
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…syntax cleanup that I needed to understand that code at least to the extent that (hopefully) enables me to fix the bash 3.x errors correctly - i.e. without breaking the functionality of the code.
|
Looks fine to me - thank you |
gdha
added a commit
that referenced
this pull request
Feb 11, 2016
fixed third time bash 3.x errors in 31_network_devices.sh
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixed third time all remaining bash 3.x errors in 31_network_devices.sh
see #758 plus heavy syntax cleanup that I needed to understand that code at least to the extent that (hopefully) enables me to fix the bash 3.x errors correctly - i.e. without breaking the functionality of the code.
I would very much appreciate it if someone with proper networking knowledge can verify if the functionality of the code is still o.k.