Resolve Issue 851: Fix problem with UUIDs on Fedora by using mkfs to … #854
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…set them instead of tune2fs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…set them instead of tune2fs.
I'm still not entirely sure why this the case, but there must be a bug in the filesystem utilities or maybe filesystem changes are cached and not committed to disk before initrd is created. For some reason when mkfs and tune2fs are used separately to retain the original filesystem UUIDs the initrd created at the end of the restore remembers and retains the original incorrect and temporary UUIDs generated by the call to mkfs...at least it does on Fedora Core 21 and maybe later resulting in a failure to boot after restore due to dracut failing to locate the filesystem with the incorrect UUIDs. This pull request avoids the use of temporary UUIDs by having mkfs use the original UUIDs directly when they are present. I've tested it and it does in fact fix the issue in a way that should not break other platforms.