ask user for EFI partition size on USB disk #906
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| read efi_part_size | ||
|
|
||
| # Check if user entered unsigned integer larger than 0 | ||
| if [[ "${efi_part_size}" =~ ^[0-9]+$ && ${efi_part_size} > 0 ]]; then |
There was a problem hiding this comment.
Concerning the > 0 test: I would use > 100 as otherwise what is the point?
There was a problem hiding this comment.
Primary intention here was only to disallow enter zero as an value, as I'm not sure how parted would handle zero as input value and was worried that such corner case could cause problems.
As user I'd welcome if I could choose arbitrary value for EFI partition size. Making this value dependent on default value sounds confusing for me.
|
@gozora |
|
@jsmeix sure ... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #849