New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added PRE-POST backup scripts #977
Conversation
…asks before and after data backup is done
@didacog Such calls are not used in the implementation for In particular if test "$PRE_BACKUP_SCRIPT" ; then ... AddExitTask "${POST_BACKUP_SCRIPT[@]}" looks like a typo. But I guess it is intentionally that POST_BACKUP_SCRIPT |
@didacog |
Is not a typo, for example: In case of no POST tasks, nothing will happen anyway. I don't know if I explained well. Regards, |
I've updated default.conf with explanation about PRE POST backup. Hope this will be ok. ;) regards, |
Hooray! @didacog |
Cool!! thanks!!! ;) |
@didacog |
@gdha |
@didacog @jsmeix @schlomo Pull requests who made it in the dev branch should first go through a QA test before we allow it in the master branch. That is the idea behind it. I do not want to cripple a release with untested commits.Otherwise, we will never come to a stable release IMHO. If it doesn't make it for this release it will be for another. However, do not yet panic. |
@gdha sounds good for me. We are working in that way in DRLM also. We use git-flow to manage: release tagging, hotfixes and features on branches from dev until merged to master. If we can help in some way we'll be pleased to do It. Regards, |
Hello,
Those changes add the capacity in rear to stop/start some services or run some required tasks previous to run backup (just like those exist for recovery), this can be useful in some scenarios if, for example, a small database that can be stopped and it's data will be consistent after OS recovery without human intervention.
I've tested and forced error between pre and post to check correct behaviour of Exit Tasks in case of any error during backup if, for example, some service stopped in PRE can be started by Exit Tasks array.
Following changed:
new file: usr/share/rear/backup/default/01_pre_backup_script.sh
new file: usr/share/rear/backup/default/99_post_backup_script.sh
modified: usr/share/rear/conf/default.conf
required configuration on /etc/rear/local.conf:
Kind regards,
Didac