Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding a missing default directory and introducing a parameter #997

Closed
wants to merge 2 commits into from
Closed

Adding a missing default directory and introducing a parameter #997

wants to merge 2 commits into from

Conversation

dl5rcw
Copy link

@dl5rcw dl5rcw commented Sep 15, 2016

I am running rear + bareos in our environment. Each client has its own fileset, thus needed a specific restore job. I noticed that I need to add a parameter to tell rear which restore job to automatically start.

I also noticed that a default folder was missing. I added this folder and rear + bareos work fine since quite a few months. It seems to be time to share this and offer this contribution.

@jsmeix jsmeix added enhancement Adaptions and new features cleanup labels Sep 16, 2016
@jsmeix jsmeix added this to the Rear future milestone Sep 16, 2016
@jsmeix
Copy link
Member

jsmeix commented Sep 16, 2016

I cannot really check anything semantically here because
I never used Bareos but I can do some superficial
mainly syntactical check:

You use a variable named BAREOS_RESTOREJOB
that I cannot find anywhere in the current rear code
but I can find a variable named BAREOS_RESTORE_JOB in
usr/share/rear/prep/BAREOS/default/55_check_bareos_restore_jobs.sh

I guess what is actually needed is an enhancement of
how BAREOS_RESTORE_JOB currently works.

In particular that BAREOS_RESTORE_JOB is documented
in usr/share/rear/conf/default.conf therein in
the "# BACKUP=BAREOS stuff (bareos.org)" section.
and that its usage is sufficiently explained there.

@gdha
because (according to "git blame")
usr/share/rear/prep/BAREOS/default/55_check_bareos_restore_jobs.sh
was made by you I assign this pull request also to you.

@jsmeix
Copy link
Member

jsmeix commented Sep 28, 2016

The curent rear master code contains in
restore/BAREOS/default/40_restore_backup.sh

            FILESET="fileset=\"$BAREOS_FILESET\""
        fi
        if [ -n "$BAREOS_RESTORE_JOB" ]
        then
            RESTOREJOB="restorejob=$BAREOS_RESTORE_JOB"
        fi
        echo "restore client=$BAREOS_CLIENT $RESTOREJOB $FILESET where=$TARGET_FS_ROOT select all done
" |     bconsole

which is the same code as in your pull request
except that BAREOS_RESTORE_JOB is used
(and not BAREOS_RESTOREJOB).

Therefore I think it is already fixed in curent rear master code
and accordingly I close this pull request as (already) "fixed".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants