Dom.nodeFilter type is wrong

[Coobaha]

https://bucklescript.github.io/bucklescript/api/Dom.html#TYPEnodeFilter

It is typed as record.

bs-webapi-incubator/tests/dom/nodes/document_test.re

Line 35 in df1585b

let _ = createNodeIteratorWithWhatToShowFilter(el, DomRe.WhatToShow.(many([_Element, _Attribute])), NodeFilter.make((_) => 0), document);

So it compiles to [() => 0] instead of { acceptNode: () => 0 };

BS issue rescript-lang/rescript-compiler#2764

[bobzhang]

is it correct to type it as < .. > Js.t ?

[Coobaha]

@bobzhang Maybe but it has defined contract please check example from mdn

The NodeIterator.filter read-only method returns a NodeFilter object, that is an object implement an acceptNode(node) method, used to screen nodes.

NodeFilter

It also has this constants that acceptNode should return

NodeFilter.FILTER_ACCEPT
NodeFilter.FILTER_REJECT
NodeFilter.FILTER_SKIP

I have this as a workaround in my project:

module NodeFilter = {
  [@bs.val] [@bs.scope "NodeFilter"]
  external filterAccept : int = "FILTER_ACCEPT";
  [@bs.val] [@bs.scope "NodeFilter"]
  external filterReject : int = "FILTER_REJECT";
  [@bs.val] [@bs.scope "NodeFilter"]
  external filterSkip : int = "FILTER_SKIP";
  type acceptNode = Dom.element => int;
  [@bs.deriving abstract]
  type t = {acceptNode};
  external castToDomNodeFilter : t => Dom.nodeFilter = "%identity";
};

Document.createNodeIteratorWithWhatToShowFilter(
  parent,
  WhatToShow._Text,
  NodeFilter.(
    t(~acceptNode=node => filterAccept)
    |> castToDomNodeFilter
  ),
  document,
);

[yawaramin]

This should be fixed with BuckleScript's records-as-objects representation. if not we can reopen.