This repository has been archived by the owner on Nov 1, 2021. It is now read-only.
Removed missing test subdirs from bsconfig.json #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 Works on my machine. |
|
Thanks! cc @chenglou could you merge this? |
|
@glennsl weird, these dirs don't exist? How did that pass before? |
|
No they don't exist yet, though they should, and should have lots of tests in them :) I assume the latest release of bs changed how directories are traversed. |
chenglou
pushed a commit
that referenced
this pull request
Feb 24, 2017
* Removed Style module, added CssStyleDeclaration * Fixed signature of a few CssStyleDeclaration functions * Added a few ofNode and ofElement functions * Removed Style module, added CssStyleDeclaration * Fixed signature of a few CssStyleDeclaration functions * Added a few ofNode and ofElement functions * Fixed Promise.make * Added reject argument to Promise.make * Fleshed out Promise * Removed a few semi-colons that were troubling webpack * Remove devDeps the esy branch is the sandboxed one * Removed Style module, added CssStyleDeclaration * Revert "Remove devDeps" This reverts commit 38de449. * Removed missing test subdirs from bsconfig.json (#21) * switch to reason-cli * Don't generate bs version comment We're tracking master and the output (and thus tests) get thrashed every time the version changes. See #17 * Added CSS2Properties + parentRule to CssStyleDeclaration (#19) * Removed Style module, added CssStyleDeclaration * Fixed signature of a few CssStyleDeclaration functions * Added a few ofNode and ofElement functions * Removed Style module, added CssStyleDeclaration * Fixed signature of a few CssStyleDeclaration functions * Added a few ofNode and ofElement functions * Fixed Promise.make * Added reject argument to Promise.make * Fleshed out Promise * Removed a few semi-colons that were troubling webpack * Added CSS2Properties + parentRule to CssStyleDeclaration * Experimental Fetch implementation (#16) * Removed Style module, added CssStyleDeclaration * Fixed signature of a few CssStyleDeclaration functions * Added a few ofNode and ofElement functions * Removed Style module, added CssStyleDeclaration * Fixed signature of a few CssStyleDeclaration functions * Added a few ofNode and ofElement functions * Fixed Promise.make * Added reject argument to Promise.make * Fleshed out Promise * Removed a few semi-colons that were troubling webpack * Fleshed out an experimental fetch implementation * Removed Style module, added CssStyleDeclaration * Moved several dom modules into functors and set up implementation inheritance between them. * Removed Style module, added CssStyleDeclaration * Experimental Fetch implementation (#16) * Removed Style module, added CssStyleDeclaration * Fixed signature of a few CssStyleDeclaration functions * Added a few ofNode and ofElement functions * Removed Style module, added CssStyleDeclaration * Fixed signature of a few CssStyleDeclaration functions * Added a few ofNode and ofElement functions * Fixed Promise.make * Added reject argument to Promise.make * Fleshed out Promise * Removed a few semi-colons that were troubling webpack * Fleshed out an experimental fetch implementation * Removed Style module, added CssStyleDeclaration * Moved several dom modules into functors and set up implementation inheritance between them. * Added subtyping experience * Added subtyping for shadowRoot
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should fix #20