Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Will this mode support Rescript too? #55

Open
marcinkoziej opened this issue Dec 21, 2020 · 8 comments
Open

Will this mode support Rescript too? #55

marcinkoziej opened this issue Dec 21, 2020 · 8 comments

Comments

@marcinkoziej
Copy link

Hello!
Will this mode support rescript as well?

@gamb
Copy link

gamb commented Apr 4, 2021

It looks like this might be quite straight forward rescript-lang/rescript-vscode#88

@Khady
Copy link
Collaborator

Khady commented Apr 5, 2021

I might be missing something, but I have the impression that the PR you linked is unrelated to the problem. reason-mode doesn't communicate with a lsp server.

@gamb
Copy link

gamb commented Apr 5, 2021

Ah, yes you're right @Khady - doh!

@yukiisbored
Copy link

There's a new major mode for rescript https://github.com/jjlee/rescript-mode. It seems to be still experimental, however.

@Khady
Copy link
Collaborator

Khady commented Sep 17, 2021

Looks like that new mode is totally based on reason-mode and is not at all acknowledging that. No history, no mention, no author names.

@Khady
Copy link
Collaborator

Khady commented Sep 17, 2021

if that new mode is good enough then I can remove the support of the .res* files that was introduced in #53
it would solve some problems mentioned in https://github.com/jjlee/rescript-mode#vanilla-emacs

@yukiisbored
Copy link

yukiisbored commented Sep 17, 2021

Looks like that new mode is totally based on reason-mode and is not at all acknowledging that. No history, no mention, no author names.

There's this small text in the commentary: jjlee/rescript-mode@328ecbb

@Khady
Copy link
Collaborator

Khady commented Sep 17, 2021

Oh I saw it just at the same time you posted your comment. Indeed there's a mention 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants