feat: add support to extension .res, .resi, .rei #53
Conversation
helderberto
force-pushed
the
feat/add-support-rescript
branch
from
852f9f2
to
0f17a91
Compare
|
There are no resi files in rescript? I'm not sure it is a good idea to have this merged. The syntax of rescript is different from the syntax of rescript. And the rescript people want to have full control of the pipeline which I guess mean they will have their own emacs mode. |
|
https://rescript-lang.org/docs/manual/latest/module#every-resi-file-is-a-signature if we want to merge this, it must be enabled on resi files too. |
helderberto
force-pushed
the
feat/add-support-rescript
branch
from
0f17a91
to
94d0b79
Compare
helderberto
changed the title
Updated to accept |
reason-mode.el
Outdated
| @@ -233,7 +233,7 @@ Argument END marks the end of the function." | |||
| (setq-local parse-sexp-lookup-properties t)) | |||
|
|
|||
| ;;;###autoload | |||
| (add-to-list 'auto-mode-alist '("\\.rei?\\'" . reason-mode)) | |||
| (add-to-list 'auto-mode-alist '("\\.\\(res\\(i\\)?\\|rei\\)$" . reason-mode)) | |||
There was a problem hiding this comment.
| (add-to-list 'auto-mode-alist '("\\.\\(res\\(i\\)?\\|rei\\)$" . reason-mode)) | |
| (add-to-list 'auto-mode-alist '("\\.\\(resi?\\|rei?\\)$" . reason-mode)) |
| (add-to-list 'auto-mode-alist '("\\.\\(res\\(i\\)?\\|rei\\)$" . reason-mode)) | |
| (add-to-list 'auto-mode-alist '("\\.res?i?$" . reason-mode)) |
your commit disables the mode for re file if I undersand it correctly. And I think it can be simplified. But I haven't tested
There was a problem hiding this comment.
You're right, I updated the regex to support the commented files.
It enables reason-mode with the following file extensions: - .re - .rei - .res - .resi
helderberto
force-pushed
the
feat/add-support-rescript
branch
from
94d0b79
to
6faf999
Compare
|
Hey @Khady, what do you think? |
|
My problem with merging this is that rescript syntax is the not the same reason syntax. So the syntax provided by this mode is not fully relevant. Also if people are using merlin/ocaml-lsp based on this mode it will also not work given the different syntax. Maybe it is better to have a different mode for rescript? I am not against merging this, I guess it can help at least temporarily. Just not sure that it is the right thing to do. |
|
I agree with you about rescript-mode will make more sense. But, like you said it's temporary. Wht do you think about we create a rescript mode? And just to start use the same code as reason-mode. If you add me to the reason-editor community I can work on this. |
|
I don't have the rights to add you to the organization. You should probably discuss the rescript mode on the rescript forum and they will guide you on where to host it. It can totally be a fork of the reason-mode to start. In the meantime I'll merge this PR as it is better than nothing. Thanks for submitting it. Please let me know if/when it is no longer necessary. |
It will enable reason-mode to .res to ReScript