Skip to content

Commit

Permalink
update for latest changes
Browse files Browse the repository at this point in the history
  • Loading branch information
anmonteiro committed Feb 1, 2024
1 parent e9da9fe commit 4a950d4
Show file tree
Hide file tree
Showing 5 changed files with 8 additions and 7 deletions.
2 changes: 1 addition & 1 deletion src/ReactDOM.re
Original file line number Diff line number Diff line change
Expand Up @@ -489,7 +489,7 @@ module Ref = {
};

/* This list isn't exhaustive. We'll add more as we go. */
[@deriving abstract]
[@deriving (jsProperties, getSet)]
type domProps = {
[@mel.optional]
key: option(string),
Expand Down
2 changes: 1 addition & 1 deletion src/ReactDOM.rei
Original file line number Diff line number Diff line change
Expand Up @@ -490,7 +490,7 @@ module Ref: {
};

/* This list isn't exhaustive. We'll add more as we go. */
[@deriving abstract]
[@deriving (jsProperties, getSet)]
type domProps = {
[@mel.optional]
key: option(string),
Expand Down
2 changes: 1 addition & 1 deletion src/ReactDOMServerNode.re
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
[@deriving abstract]
[@deriving (jsProperties, getSet)]
type options = {
[@mel.optional]
bootstrapScriptContent: option(string),
Expand Down
3 changes: 1 addition & 2 deletions src/ReactDOMServerNode.rei
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
[@deriving abstract]
[@deriving (jsProperties, getSet)]
type options = {
[@mel.optional]
bootstrapScriptContent: option(string),
Expand Down Expand Up @@ -45,5 +45,4 @@ let renderToPipeableStream:
~progressiveChunkSize: int=?,
React.element
) =>

pipeableStream;
6 changes: 4 additions & 2 deletions test/React__test.re
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ module DummyComponentThatMapsChildren = {
{children->React.Children.mapWithIndex((element, index) => {
React.cloneElement(
element,
{"key": {j|$index|j}, "data-index": index},
{"key": string_of_int(index), "data-index": index},
)
})}
</div>;
Expand Down Expand Up @@ -133,7 +133,9 @@ describe("React", () => {
let container = getContainer(container);
let array =
[|1, 2, 3|]
->Array.map(item => {<div key={j|$item|j}> item->React.int </div>});
->Array.map(item => {
<div key={string_of_int(item)}> item->React.int </div>
});
let root = ReactDOM.Client.createRoot(container);

act(() => {
Expand Down

0 comments on commit 4a950d4

Please sign in to comment.