Add binding for name and displayName #433
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rickyvetter
suggested changes
Apr 22, 2020
src/React.re
Outdated
|
|
||
| [@bs.get] | ||
| external getDisplayName: component('props) => Js.undefined(string) = | ||
| "displayName"; |
There was a problem hiding this comment.
Let's use [@bs.return nullable] on these - see #526 as an example to get a better api on the Reason side. Also I think we should make the API match and just call displayName and name.
There was a problem hiding this comment.
Thanks @rickyvetter 🙌
[@bs.return nullable] is nice!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added binding for
nameanddisplayNameof the React Component.