Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RFC: ReactDOM simplification #547

Merged
merged 2 commits into from
May 26, 2020

Conversation

bloodyowl
Copy link
Contributor

Suggestions for 0.9.0

  • Moved files to be deprecated into a legacy dir
  • Moved ReactDOM.Style into its own file (still aliased in ReactDOM)
  • Removed *WithId and *WithClassName helpers in favor of a querySelector
    binding (meaning no runtime for ReactDOM at all)

Related: #528

Suggestions for 0.9.0

- Moved files to be deprecated into a legacy dir
- Moved ReactDOM.Style into its own file (still aliased in ReactDOM)
- Removed *WithId and *WithClassName helpers in favor of a querySelector
binding (meaning no runtime for ReactDOM at all)
@bloodyowl bloodyowl changed the title React dom simplification ReactDOM simplification Apr 28, 2020
@bloodyowl bloodyowl changed the title ReactDOM simplification RFC: ReactDOM simplification Apr 28, 2020
@peterpme peterpme added the RFC label Apr 29, 2020
@peterpme peterpme added the 0.9.0 label Apr 29, 2020
@rickyvetter rickyvetter merged commit a263261 into reasonml:master May 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants