Add uncurried hooks

[johnridesabike]

let (count, setCount) = React.Uncurried.useState(() => 0);
setCount(. a => a + 1);

The original pull request for this got messed up, so this is re-opening it.

Original PR: #529

Fixes: #530

[rickyvetter]

I think I was getting a little aggressive here. Since they are externals bs.uncurry should be enough. Please swap reducer back to [@bs.uncurry] and then rebuild to resolve conflicts and we can get this in!

[rickyvetter]

Swap this input back.

[rickyvetter]

Unrelated to your PR but I think this is unsafe. Should probably add bs.uncurry here as well.

[johnridesabike]

Do you think we should go ahead and add [@bs.uncurry] to that argument on the regular useReducerWithMapState too?

[rickyvetter]

Yes. As a separate PR that would be great.

[rickyvetter]

Pretty sure you want to do all of the callback type returns as well = https://reasonml.github.io/try?rrjsx=true&reason=C4TwDgpgBAxghgGwQIzjA1gCgOQEsA0U2A9gJRQC8RulAfEcQNwBQzA2gALIDOAdALbEAJgFcE0AEQAnCGmASAusyhQIAD2AQpAO0RQR3CAGFEKNOgBcylVEycevEdpgipUkAtt5tYEcDoMfr7ApOQU9PBIqBg4uD5+hCRBfmHWKhIGxqbR6BIszOL+AGbExJS2YfQA3gUQ-obARsRO-lSZJlHmmJiVUAAMpCwNTS09LAC+jEA

[johnridesabike]

All of the Uncurried.useCallback* functions should return type Uncurried.callback, defined as type callback('input, 'output) = (. 'input) => 'output;

https://reasonml.github.io/try?rrjsx=true&reason=C4TwDgpgBAxghgGwQIzjA1gCgOQEsB2YArsADRTYD2JxwAlFALxSYB0FBtDjAfBdcFoBuAFAiA2gAFkAZ1YBbSgBMiCaACIAThDTB1AXREQAHsAib8iKERkQAwohRp0ALhFQWU2ayL4YRTU0QfRY8QhImPioaEjpuPngkVAwcThJyaMFYpncodRt7R2T0dVERNWAoADNKSiYWeKgAb1yKqFtgO2p8SuYChyTnTDhIqBGAaigARjpRDw6u32A2KAAGWZEAX1EgA

However I did just discover another bug. It doesn’t look like Reason is good at handling arity-zero uncurried functions. I’m not sure what the best way around that is, unless I’m missing something.

https://reasonml.github.io/try?rrjsx=true&reason=C4TwDgpgBAxghgGwQIzjA1gCgOQEsB2YArsADRTYD2JxwAlFALxSYB0FBtDjAfBdcFoBuAFAiA2gAFkAZ1YBbSgBMiCaACIAThDTB1AXREQAHsAib8iKERkQAwohRp0ALhFQWU2ayL4YRTU0QfRY8QhImPioaEjpuPngkVAwcThJyaMFYpncodRt7R2T0dVERNWAoADNKSiYWeKgAb1yKqFtgO2p8SuYChyTnTExGgAY6UQ8Ort9gNgmRAF9RIA

Seems to be related to reasonml/reason#2357

[rickyvetter]

Oh I was oblivious. Good call for keeping continuity with the other set.

Yah that issue provides a workaround but it is kind of annoying that this error exists. I don't think it should block this PR though - if the feature is never used then a better experience won't be prioritized.

[yawaramin]

@johnridesabike if #574 gets merged, your diff will shrink to only two bindings per hook :-)

[peterpme]

@johnridesabike @rickyvetter all good here? Would love to get this in a state of mergeability 😄

[johnridesabike]

@peterpme I don't have anything else I'm waiting for. Merging is fine with me as long as no one else has any issues.