Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ocaml lsp editor #699

Merged
merged 9 commits into from
Dec 20, 2022
Merged

Add ocaml lsp editor #699

merged 9 commits into from
Dec 20, 2022

Conversation

davesnx
Copy link
Member

@davesnx davesnx commented Dec 16, 2022

This PR makes the editor work fine when developing this repository. It uses opam to install ocaml-lsp, reason and merlin.

@davesnx davesnx changed the base branch from aria-attributes-missing to master December 20, 2022 13:26
@davesnx davesnx merged commit 6306c20 into master Dec 20, 2022
davesnx added a commit that referenced this pull request Dec 20, 2022
@davesnx
Merge branch 'master' of github.com:/reasonml/reason-react into Upgra…
b6edc08 
…de-bs-platform-to-902

* 'master' of github.com:/reasonml/reason-react:
  Add ocaml lsp editor (#699)
  Add all aria attributes (#697)
  Update Drag.dataTransfer to Js.t (#701)
  Add drag event API binding (#641)
  Added `as` property to DOM props (#603)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rolandpeelen rolandpeelen rolandpeelen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@davesnx @rolandpeelen