Better error message for modules with lowercase identifiers (#2062)

* Better error message for modules with lowercase identifiers fixes #1974 * rebase + wip error message
reasonml · Jul 11, 2018 · 7d44d1c · 7d44d1c
1 parent 6cfddf9
commit 7d44d1c
Show file tree

Hide file tree

Showing 6 changed files with 1,228 additions and 1,392 deletions.
diff --git a/formatTest/errorTests/expected_output/lowercase_module.re b/formatTest/errorTests/expected_output/lowercase_module.re
@@ -0,0 +1,2 @@
+File "lowercase_module.re", line 1, characters 7-16:
+Error: Module names must start with an uppercase letter.
diff --git a/formatTest/errorTests/expected_output/lowercase_module_rec.re b/formatTest/errorTests/expected_output/lowercase_module_rec.re
@@ -0,0 +1,2 @@
+File "lowercase_module_rec.re", line 1, characters 11-20:
+Error: Module names must start with an uppercase letter.
diff --git a/formatTest/errorTests/input/lowercase_module.re b/formatTest/errorTests/input/lowercase_module.re
@@ -0,0 +1 @@
+module lowercase = {};
diff --git a/formatTest/errorTests/input/lowercase_module_rec.re b/formatTest/errorTests/input/lowercase_module_rec.re
@@ -0,0 +1 @@
+module rec lowercase = {};