Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Print newline after doc comments before attributes #1869

Merged
merged 3 commits into from Jun 5, 2018
Merged

Print newline after doc comments before attributes #1869

merged 3 commits into from Jun 5, 2018

Commits on May 24, 2018

  1. newline between doc comment and attr on external 

    Forces a line break following doc comments before the first
non-comment attribute on a BuckleScript external.

Before:

/** doc comment */ [@bs.send] external url : t => string = "";

/**
 * Short multiline doc comment
 */ [@bs.send]
external url : t => string = "";

After:

/** doc comment */
[@bs.send]
external url : t => string = "";

/**
 * Short multiline doc comment
 */
[@bs.send]
external url : t => string = "";
    @zploskey
    zploskey committed May 24, 2018
    Copy the full SHA
    37da429 View commit details
    Browse the repository at this point in the history

  2. Add tests for doc comments on type and let

    @zploskey
    zploskey committed May 24, 2018
    Copy the full SHA
    b3d4698 View commit details
    Browse the repository at this point in the history

  3. Use partitionAttributes now that it handles docs 

    Doc comments were previously disabled.
    @zploskey
    zploskey committed May 24, 2018
    Copy the full SHA
    3ad1c82 View commit details
    Browse the repository at this point in the history