Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add adjustable padding for nested nodes and add storybook story for custom nested nodes #30

Merged
merged 9 commits into from Dec 15, 2020

Conversation

ASchwad
Copy link
Contributor

@ASchwad ASchwad commented Dec 10, 2020

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[X] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[X] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

The node content might get "covered" by nested nodes and there is currently no way to provide a padding for nodes within a node.

Issue Number: #28

What is the new behavior?

The padding towards nested nodes can now be adjusted for individual nodes.

Does this PR introduce a breaking change?

[ ] Yes
[X] No

Other information

Naming might be ambigous - Open for suggestions! maybe "innerPadding" or "nestedPadding" is more intuitive, because the actual node content is not affected by the padding.

Copy link
Member

@amcdnl amcdnl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome stuff - few minor reqs

src/layout/elkLayout.ts Outdated Show resolved Hide resolved
stories/Nested.stories.tsx Outdated Show resolved Hide resolved
@ASchwad
Copy link
Contributor Author

ASchwad commented Dec 13, 2020

@amcdnl Integrated your feedback into the PR

Copy link
Member

@amcdnl amcdnl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

need to fix the type otherwise lgtm

src/types.ts Outdated Show resolved Hide resolved
src/layout/utils.ts Outdated Show resolved Hide resolved
@ASchwad ASchwad requested a review from amcdnl December 15, 2020 20:19
@amcdnl amcdnl merged commit b0511ae into reaviz:master Dec 15, 2020
@amcdnl
Copy link
Member

amcdnl commented Dec 16, 2020

release 2.4.5 w/ this change

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants