Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Edge.tsx #46

Merged
merged 2 commits into from
Jul 8, 2022
Merged

Update Edge.tsx #46

merged 2 commits into from
Jul 8, 2022

Conversation

Its-Just-Nans
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

In the docs, there is :

export interface SelectionResult {
  /**
   * Selections id array (of nodes and edges).
   */
  selections: string[];
}

but when you give some id of egdes, it's not working

This PR solves this problem, and docs are now correct

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[x] Other... Please describe:

What is the current behavior?

When I gave the selections props as an array of strings, containing id of edges, the edges are not selected

What is the new behavior?

When I gave the selections props as an array of strings, containing id of edges, the edges are now selected

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

Copy link
Member

@amcdnl amcdnl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just need a simple tweak otherwise good.

src/symbols/Edge.tsx Outdated Show resolved Hide resolved
Co-authored-by: Austin <amcdaniel2@gmail.com>
@amcdnl amcdnl merged commit 3158ace into reaviz:master Jul 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants