Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use theme to define opacity #49

Merged
merged 5 commits into from
Jul 26, 2022
Merged

Use theme to define opacity #49

merged 5 commits into from
Jul 26, 2022

Conversation

Its-Just-Nans
Copy link
Contributor

@Its-Just-Nans Its-Just-Nans commented Jul 12, 2022

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

Use the theme to set a custom opacity

What is the current behavior?

We cannot change the opacity

Issue Number: N/A

What is the new behavior?

We can change the opacity

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

Copy link
Member

@amcdnl amcdnl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall. Can you update those variables names?

docs/Theme.story.mdx Outdated Show resolved Hide resolved
@Its-Just-Nans
Copy link
Contributor Author

Its-Just-Nans commented Jul 26, 2022

Yes I have updated names :
25a8d83

src/symbols/Edge.tsx Outdated Show resolved Hide resolved
@amcdnl amcdnl merged commit 4de2009 into reaviz:master Jul 26, 2022
@amcdnl
Copy link
Member

amcdnl commented Jul 26, 2022

published 3.0.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants