Skip to content

Fix reset_after_eunit function to stop applications that were loaded during the test runs. #197

Closed
wants to merge 1 commit into from

4 participants

@nlebedenco

The original implementation used a list comprehension to account for the applications to be stopped,
but the code didn't work as expected leaving applications still running. These applications would later be
killed by the kill_extras function resulting in errors. This fix computes the applications that
must be stopped/unloaded using a digraph of dependencies. I noticed the problem while trying to run eunit tests from lager as a dependency of a project of mine: basho/lager#181. After digging into the problem I came up with the proposed solution. The only thing I'm not sure about is the need to call reconstruct_app_env_vars(Apps). I started to think that we should actually call reconstruct_app_env_vars(OldApps), but I leave the question open for the gurus.

@nlebedenco nlebedenco Fix reset_after_eunit function to stop applications that were loaded …
…buring the test runs.

The original implementation used a list comprehension to account for the applications to be stopped,
but the code didn't work as expected leaving applications still running. These applications would later be
killed by the kill_extras function resulting in errors. This fix computes the applications that
must be stopped/unloaded using a digraph of dependencies.
52fa8b8
@ghost
ghost commented Jan 20, 2014

Perhaps interesting to merge with #216

@tuncer
tuncer commented Jan 21, 2014

Regardless of whether we merge this patch, maybe we should use a slave node for isolation of test runs or test cases (see discussion in #217).

@tsloughter tsloughter closed this Jun 15, 2014
@tuncer
tuncer commented Jun 15, 2014

@tsloughter why did you close this?

@ferd
ferd commented Jun 15, 2014

Hi, this issue was closed in an attempt to do quick basic filtering, with the benediction of rebar project owners. These issues and pull requests are not issues or code we're spitting on, but given the burden of the task and how much code rot may have happened since these were open is unknown from maintainers at this time. All tickets prior to March 2014 were closed and will be reopened on a per-request basis if we see interest from the reporter or contributor, or if some of the issues reported are still valid after the various patches that have made it since they were opened.

This is a fairly brutal first step to help us get a proper understanding of what is still valid or not, but that has been proven efficient in the past. Sorry for the inconvenience, things should go smoother from there on.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.