Extra commits for #129 #242

Merged
merged 4 commits into from May 19, 2014

3 participants

@tuncer

Extra commits for #129
1. fix a log message
2. add erlc test suite

@Vagabond

The tests are failing on R14?

@tuncer

Fixed R13 and R14 compatibility.

@Vagabond

What did you change?

@tuncer

R13 and R14 require behaviour_info/1 instead of the callback attribute. So, if we're testing on R13 or R14, then the behaviour module is compiled with an extra define.

@Vagabond

Why are you rebasing this constantly? I just saw you do it twice in the last minute!

Please let me know when this is actually ready for me to look at!

@tuncer

Had to simplify the compatibility fix, and it's done now.

@tuncer tuncer closed this Mar 12, 2014
@tuncer tuncer deleted the tuncer:erlc-speedup-v5-fixup branch Mar 12, 2014
tuncer added some commits Mar 5, 2014
@tuncer tuncer erlc: add test suite b2dfeba
@tuncer tuncer erlc: fixup log message
Using the filename as a prefix is less readable and inconsistent with
the other log messages.

Before:

DEBUG: src/foo.erl depends on...

After:

DEBUG: Dependencies of src/foo.erl ...
fe9d328
@Vagabond

Why did you close this?

@tuncer tuncer reopened this Mar 12, 2014
@tuncer

By accident. Do I have to submit a new one, or can this still be merged cleanly?

@Vagabond

This is fine, I will review it when I get time.

@tuncer

ping

@tuncer

ping

@tuncer

@jaredmorrow, @Vagabond can we get this merged?

@jaredmorrow jaredmorrow merged commit fdb66ec into rebar:master May 19, 2014

1 check passed

Details default The Travis CI build passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment