This repository has been archived by the owner on May 12, 2018. It is now read-only.
Extra commits for #129 #242
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
mentioned this pull request
|
The tests are failing on R14? |
Fix typo in rebar_erlydtl_compiler
|
Fixed R13 and R14 compatibility. |
|
What did you change? |
|
R13 and R14 require behaviour_info/1 instead of the callback attribute. So, if we're testing on R13 or R14, then the behaviour module is compiled with an extra define. |
|
Why are you rebasing this constantly? I just saw you do it twice in the last minute! Please let me know when this is actually ready for me to look at! |
|
Had to simplify the compatibility fix, and it's done now. |
ghost
closed this
ghost
deleted the
added 2 commits
March 12, 2014 20:45
Using the filename as a prefix is less readable and inconsistent with the other log messages. Before: DEBUG: src/foo.erl depends on... After: DEBUG: Dependencies of src/foo.erl ...
|
Why did you close this? |
ghost
reopened this
|
By accident. Do I have to submit a new one, or can this still be merged cleanly? |
|
This is fine, I will review it when I get time. |
|
ping |
1 similar comment
|
ping |
ghost
mentioned this pull request
|
@Vagabond ping? |
|
@jaredmorrow, @Vagabond can we get this merged? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extra commits for #129