Quote include/lib paths

[dgud]

In OTP-17.0 paths on windows are not shortpaths anymore
so they may contain spaces and parenthesis

[ghost]

IIUC, this is only an issue on Windows, so shouldn't we restrict it to Windows? That way the change would not affect non-Windows platforms.

[dgud]

You can do what you want, but if someone installed erlang with a space in
the path
on another platform they will get in trouble if the paths are not quoted.
Maybe Windows users moving to Linux or Darwin, will do that..
I know we handle that in erlang, we have a machine that does that.

The problem probably exists in another places, I didn't look, but this one
fixed the urgent
problem more me.

I have only (currently) tested it on windows as well :-)

On Wed, Apr 9, 2014 at 10:16 PM, Tuncer Ayaz notifications@github.comwrote:

IIUC, this is only an issue on Windows, so shouldn't we restrict it to
Windows? That way the change would not affect non-Windows platforms.

Reply to this email directly or view it on GitHubhttps://github.com//pull/260#issuecomment-40011194
.

[ghost]

Good point :).

[ghost]

+1

[ferd]

Shouldn't this also care for other characters? Escaping " at the very least?

[tsloughter]

@dgud ping?

[dgud]

Pick this fix, or write a better one I don't care.
See my patch as an bug-report with workaround.
Rebar on windows is currently not working.

[ferd]

Given things are broken right now, we should possibly hurry this one in and deal with quotation issues when it arises -- or note it as a follow-up issue. @Tuncer @tsloughter agreed?

[ghost]

+1

[tsloughter]

+1